Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore broken symlinks #832

Merged
merged 7 commits into from
Jun 16, 2024
Merged

fix: ignore broken symlinks #832

merged 7 commits into from
Jun 16, 2024

Conversation

vdayanand
Copy link
Contributor

@vdayanand vdayanand commented May 2, 2024

Currently formatting breaks if it encounters broken symlink in the directory

@vdayanand
Copy link
Contributor Author

Looks like the CI failure is unrelated?

@pfitzseb
Copy link
Contributor

pfitzseb commented May 3, 2024

Yeah, the Julia 1.4 distribution for MacOS is broken. I'd suggest adding a exclusion:

        exclude:
          - os: macos-13
          - julia-version: 1.4

Also probably a good idea to switch back to macos-13 for now, macos-latest got switched to ARM machines or something recently.

@vdayanand
Copy link
Contributor Author

Also probably a good idea to switch back to macos-13 for now, macos-latest got switched to ARM machines or something recently.

Did you mean switching to macos-latest (which is currently excluded) instead of macos-13?

@pfitzseb
Copy link
Contributor

pfitzseb commented May 3, 2024

I meant using macos-13 globally and excluding Julia 1.4. I've also been using the juliaup action recently -- here's how that would look like

...
    strategy:
      matrix:
        julia-version: ['1.0', '1.1', '1.2', '1.3', '1.4', '1.5', '1.6', '1.7', '1.8', '1.9', '1.10', '1.11']
        os: [ubuntu-latest, windows-latest, macos-13]
        exclude:
          - os: macos-13
          - julia-version: 1.4
    steps:
      - uses: actions/checkout@v4
      - uses: julia-actions/install-juliaup@v1
        with:
           julia-version: ${{matrix.julia-version}}
...

@vdayanand
Copy link
Contributor Author

Thanks. I have updated the CI

@vdayanand vdayanand requested a review from domluna May 3, 2024 14:10
@domluna
Copy link
Owner

domluna commented May 3, 2024

why isnt the ci running hmmm

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Sebastian Pfitzner <pfitzseb@gmail.com>
- os: macos-latest
arch: x86
- os: macos-13
version: 1.4

This comment was marked as outdated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see PR #847

@kimikage kimikage mentioned this pull request Jun 16, 2024
@domluna domluna merged commit 93ca402 into domluna:master Jun 16, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants